fix(app): disable Markdown tables after Android layout failure #71

Merged

morten-olsen merged 3 commits from fix/01a158a9-disable-tables into main 2026-10-20 21:36:07 +02:00

Conversation 1 Commits 3 Files changed 5 +72 -77

morten-olsen commented 2026-10-20 21:22:08 +02:00

Owner

• Copy link
• Copy Markdown

Summary

Morten’s v0.50.0 Android test found that tables break the view. Disable table parsing across Android and web and remove the custom table layout; pipe-table syntax becomes ordinary selectable paragraph text. Stored Markdown and all other rendering/editing behavior are preserved.

pipe-table source → shared parser (tables disabled) → existing themed paragraph

Evidence

• Before: Morten’s Android report; new source regression fails because table tokens are generated.
• After: source regression passes with paragraph fallback and exact checkbox targeting around table text. task ci:quality passes (868 tests, 129 files), app/E2E type checks and focused ESLint pass. All 8 phone/desktop browser checks pass, including fallback on description/activity/conversation, saved-source preservation and existing interactions. Before/after screenshots are attached to the task. Branch #486 and PR #487 are fully green, including docs and both image builds.
• Owner self-review: Standards 0 findings; Spec 0 findings.
• Native rendering of the fix remains pending Morten’s patched-APK retest under his existing merge/release approval.

Merge danger

Door: two-way. Reverting restores table support; no schema or stored Markdown changes.

Blast radius: app.

Rollback and verification

• Roll back: revert this patch in a compatible release; retain data and migrations.
• Verify after rollout: green coordinated release, expected server/agent digests and Argo revision, deployed web fallback and existing interactions at phone/desktop widths; then Morten’s Android retest.
• Reviewers: owner Standards/Spec self-review. Removing table layout adds no security capability or exposure; no required security review or requested Designer sign-off.

## Summary Morten’s v0.50.0 Android test found that tables break the view. Disable table parsing across Android and web and remove the custom table layout; pipe-table syntax becomes ordinary selectable paragraph text. Stored Markdown and all other rendering/editing behavior are preserved. `pipe-table source → shared parser (tables disabled) → existing themed paragraph` ## Evidence - Before: Morten’s Android report; new source regression fails because table tokens are generated. - After: source regression passes with paragraph fallback and exact checkbox targeting around table text. `task ci:quality` passes (868 tests, 129 files), app/E2E type checks and focused ESLint pass. All 8 phone/desktop browser checks pass, including fallback on description/activity/conversation, saved-source preservation and existing interactions. Before/after screenshots are [attached to the task](https://mission-control.olsen.cloud/task/01a158a9-391a-7466-a21d-4e47c8d1aee3). [Branch #486](https://woodpecker.olsen.cloud/repos/32/pipeline/486) and [PR #487](https://woodpecker.olsen.cloud/repos/32/pipeline/487) are fully green, including docs and both image builds. - Owner self-review: Standards 0 findings; Spec 0 findings. - Native rendering of the fix remains pending Morten’s patched-APK retest under his existing merge/release approval. ## Merge danger **Door:** two-way. Reverting restores table support; no schema or stored Markdown changes. **Blast radius:** app. ## Rollback and verification - **Roll back:** revert this patch in a compatible release; retain data and migrations. - **Verify after rollout:** green coordinated release, expected server/agent digests and Argo revision, deployed web fallback and existing interactions at phone/desktop widths; then Morten’s Android retest. - **Reviewers:** owner Standards/Spec self-review. Removing table layout adds no security capability or exposure; no required security review or requested Designer sign-off.

morten-olsen added 1 commit 2026-10-20 21:22:08 +02:00

fix(app): disable Markdown tables after Android layout failure 0a778c9aae

morten-olsen added 1 commit 2026-10-20 21:23:51 +02:00

test(app): cover table fallback across Markdown surfaces 3f7a21d0e4

morten-olsen added 1 commit 2026-10-20 21:25:38 +02:00

test(app): isolate Markdown browser checks across viewports 72bdbff5c4

morten-olsen reviewed 2026-10-20 21:25:56 +02:00

morten-olsen left a comment

• Copy link
• Copy Markdown

Owner self-review: 0a778c9 against 57a858b, plus subsequent browser-fixture corrections. Standards: zero findings. Spec: zero findings. Parallel checks confirmed the supported table parser toggle and removal of custom table rules preserve existing shared rendering, source and checkbox behavior. Browser fixtures now match the entire selectable pipe paragraph, check fallback in description/activity/conversation, use distinct per-viewport message labels and read selection atomically to avoid test collisions. Source regression was red before and green after. Actual Android fallback is pending Morten’s patched-APK test under existing release approval. Verify expected release digests/revision and deployed web fallback; rollback via compatible revert release without source/schema changes.

Owner self-review: 0a778c9 against 57a858b, plus subsequent browser-fixture corrections. Standards: zero findings. Spec: zero findings. Parallel checks confirmed the supported table parser toggle and removal of custom table rules preserve existing shared rendering, source and checkbox behavior. Browser fixtures now match the entire selectable pipe paragraph, check fallback in description/activity/conversation, use distinct per-viewport message labels and read selection atomically to avoid test collisions. Source regression was red before and green after. Actual Android fallback is pending Morten’s patched-APK test under existing release approval. Verify expected release digests/revision and deployed web fallback; rollback via compatible revert release without source/schema changes.

morten-olsen merged commit 7170d5b811 into main 2026-10-20 21:36:07 +02:00

morten-olsen referenced this pull request from a commit 2026-10-20 21:36:09 +02:00

fix(app): disable Markdown tables after Android layout failure (#71)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ai/mission-control!71

No description provided.